This repository has been archived by the owner on Apr 1, 2022. It is now read-only.
General Little Improvements #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alereca
reviewed
Apr 6, 2021
| @@ -3,7 +3,8 @@ | |||
| <mat-form-field class="search-bar"> | |||
| <mat-label>Buscar proyectos</mat-label> | |||
| <input matInput placeholder="Por nombre de proyecto o por usuario" formControlName="generalSearch" /> | |||
| <mat-icon matSuffix (click)="onSubmit()">search</mat-icon> | |||
| <mat-icon *ngIf="generalSearchValid()" matSuffix>search</mat-icon> | |||
| <mat-icon *ngIf="!generalSearchValid()" matSuffix type="button" class="submitIcon" (click)="onSubmit()">check</mat-icon> | |||
There was a problem hiding this comment.
Puede ser que no se vea clickeable en desktop?
There was a problem hiding this comment.
Tal vez deberiamos usar mat-button aca tambien en lo posible
alereca
force-pushed
the
General-little-improvements
branch
from
5e69e5f
to
13dd8ee
Compare
alereca
force-pushed
the
General-little-improvements
branch
from
fc267ab
to
8b1f63b
Compare
alereca
force-pushed
the
General-little-improvements
branch
from
8b1f63b
to
8d3e469
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Little Improvements