Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug with incorrect shimmering size after requestLayout called #57

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

VitalyNikonorov
Copy link

There is incorrect shimmer animation after child view has been changed.
E.g.

        childView.setText(newText);
        shimmerLayout.startShimmerAnimation();

If length of newText and text in childView is differ, than shimmer animation will be not correct

@veghtomi
Copy link
Contributor

Hi @VitalyNikonorov, thanks for the pull request. I will have a look at it at the end of the week!

@veghtomi
Copy link
Contributor

@VitalyNikonorov I checked the pull request. So yes, there is this bug that if you change the text for example after measure and layout phase and start the animation.

However, if the animation is ongoing and I change the text, the animation will not be proper after applying your fix.

Copy link
Contributor

@veghtomi veghtomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the conversation.

@VitalyNikonorov
Copy link
Author

@veghtomi I've made some changes. Now animation works with correct animating interval, but it does not take into account the correct position of shimmer mask (interpolator and size changes adjustment is required)

@veghtomi
Copy link
Contributor

veghtomi commented Sep 3, 2018

@VitalyNikonorov thanks for the fix, I will check it soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants