improvement: register with magic link #795
Conversation
registering with magic link turns the read action used to request a magic link into an upsert action. improvement: support `auto_confirm_actions` on confirmation addon these actions will automatically apply their confirmation attribute, and will not invoke the sender improvement: support `ignore_actions` on confirmation addon these actions will not apply their confirmation attribute, and will not invoke the sender
|
Well. I implemented this as upserts and then I found the issue mentioning this and reading your explanation of how it ought to be done I now know that I did it completely wrong 😆 |
|
Maybe? I'm actually not sure. The benefits of doing it as an upsert like this are that it can be done atomically. If we do a read, then create a sign up token, we introduce race conditions/potential weird behavior, like having to handle cases where you've requested a token, not used it, signed up using email, in which case it would look like you're trying to sign up for an account that exists. This way is quite simple by comparison. |
|
As I'm implementing protections around upserting against unconfirmed users, I'm even more convinced that an upsert is the right call here. Because then we get immediate feedback that the user already has an account. |
|
Alright, now I'm not so sure 😆 @jimsynz lets circle back, we can discuss how this has all gone for me and figure out a way forward :) |
|
Alright, just going to close this. It was done incorrectly :D |
registering with magic link turns the read action used to request a magic link into an upsert action.
improvement: support
auto_confirm_actionson confirmation addonthese actions will automatically apply their confirmation attribute, and will not invoke the sender
improvement: support
ignore_actionson confirmation addonthese actions will not apply their confirmation attribute, and will not invoke the sender
Closes #554