Common 213 #38
Common 213 #38
Conversation
common-wpi-util/src/main/java/com/team2073/common/mediator/Mediator.java
Outdated
Show resolved
Hide resolved
common-wpi-util/src/main/java/com/team2073/common/mediator/Mediator.java
Outdated
Show resolved
Hide resolved
common-wpi-util/src/main/java/com/team2073/common/mediator/subsys/SubsystemStateCondition.java
Show resolved
Hide resolved
common-wpi-util/src/main/java/com/team2073/common/mediator/condition/PositionBasedCondition.kt
Outdated
Show resolved
Hide resolved
common-wpi-util/src/main/java/com/team2073/common/mediator/Mediator.java
Outdated
Show resolved
Hide resolved
common-wpi-util/src/main/java/com/team2073/common/mediator/Mediator.java
Outdated
Show resolved
Hide resolved
common-wpi-util/src/main/java/com/team2073/common/mediator/Mediator.java
Outdated
Show resolved
Hide resolved
|
|
||
| if (islowerBound == null) { | ||
| if (isLowerBound == null) { | ||
| println("bound not upper/lower in condition") |
There was a problem hiding this comment.
Shouldn't this be an exception?
There was a problem hiding this comment.
If you threw an exception here then maybe you could make resolutionCondition not be lateinit (or maybe just return it from inside the if statements and get rid of the var all together)
| return originCondition == originConditionP && conflictingCondition == conflictingConditionP | ||
| } | ||
|
|
||
| override fun getResolution(currentCondition: Condition<Double>, subsystem: ColleagueSubsystem<Double>): Condition<Double> { |
There was a problem hiding this comment.
You should look into just using the Position class I made. I think it does basically what you are trying to do here.
There was a problem hiding this comment.
The position class doesn't tell me the closest bound and doesn't pass back the closest bound though
| return originCondition == originConditionPS && conflictingCondition == conflictingConditionPS | ||
| } | ||
|
|
||
| override fun getResolution(currentCondition: Condition<Double>, subsystem: ColleagueSubsystem<Double>): Condition<Double> { |
There was a problem hiding this comment.
Find a way to not repeat this code in the various condition classes. You are gonna make changes later and forget to update all the different areas.
minhn02
force-pushed
the
COMMON-213
branch
3 times, most recently
from
af4a738 to
a80ff12
Compare
minhn02
force-pushed
the
COMMON-213
branch
3 times, most recently
from
6e0daa0 to
d83e675
Compare
minhn02
force-pushed
the
COMMON-213
branch
4 times, most recently
from
f2ab703 to
c93c8d0
Compare
…n creating Requests
…ct changes to accommodate two enums
No description provided.