feat: used react fragment for better classname handling

tea-lover-418 · Jun 4, 2022 · e4f6429 · e4f6429
1 parent a55e920
commit e4f6429
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-loading-iframe",
-  "version": "1.0.4",
+  "version": "1.1.0",
   "description": "",
   "source": "src/index.tsx",
   "main": "dist/main.js",

diff --git a/src/index.tsx b/src/index.tsx
@@ -1,5 +1,6 @@
 import * as React from "react";
 import {
+  Fragment,
   FunctionComponent,
   IframeHTMLAttributes,
   ReactElement,
@@ -11,6 +12,7 @@ interface Props extends IframeHTMLAttributes<any> {
   skeleton?: ReactElement;
 }
 
+/** An iframe that takes a skeleton as a prop and renders the skeleton until the iframe is ready */
 const LoadingIframe: FunctionComponent<Props> = (props) => {
   const { skeleton, className, ...iframeProps } = props;
   const [iframeLoading, setIframeLoading] = useState(true);
@@ -22,9 +24,10 @@ const LoadingIframe: FunctionComponent<Props> = (props) => {
   }
 
   return (
-    <div className={className}>
+    <Fragment>
       {iframeLoading && skeleton}
       <iframe
+        className={className}
         {...iframeProps}
         style={{
           display: iframeLoading ? "none" : "block",
@@ -35,7 +38,7 @@ const LoadingIframe: FunctionComponent<Props> = (props) => {
           setIframeLoading(false);
         }}
       />
-    </div>
+    </Fragment>
   );
 };
 

diff --git a/tsconfig.json b/tsconfig.json
@@ -18,8 +18,7 @@
     "suppressImplicitAnyIndexErrors": true,
     "noUnusedLocals": true,
     "skipLibCheck": true,
-    "allowSyntheticDefaultImports": true,
-    "removeComments": true
+    "allowSyntheticDefaultImports": true
   },
   "include": ["/src/*/*.tsx", "/src/*/*.ts"],
   "exclude": [