Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atime_pkg gains tests.R.path arg #41

Merged
merged 5 commits into from
Apr 12, 2024
Merged

atime_pkg gains tests.R.path arg #41

merged 5 commits into from
Apr 12, 2024

Conversation

tdhock
Copy link
Owner

@tdhock tdhock commented Apr 12, 2024

requested so that data.table can put tests R code file under .ci dir, Rdatatable/data.table#6078

R/versions.R Outdated
@@ -169,7 +169,7 @@ atime_versions_exprs <- function(pkg.path, expr, sha.vec=NULL, verbose=FALSE, pk
a.args
}

atime_pkg <- function(pkg.path="."){
atime_pkg <- function(pkg.path=".", tests.R.path=file.path("inst", "atime", "tests.R"))){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even tests.dir would be enough, it could be nice to require ${dir}/atime/tests.R for consistency.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I updated, is that what you meant?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks great.

@tdhock tdhock merged commit 200f184 into main Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants