Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override media controller #97

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lintax
Copy link

@lintax lintax commented May 9, 2018

Currently it is quite easy to customize the player on the level of DefaultMediaController (almost anything is protected) and BaseMediaController

However, the VideoView itself is bind to a single implementation, so requires a copy-paste of it + impossibility to reuse BaseMediaController or it's implementation due to fact that BaseMediaController.bind is binded to VideoView class itself.

So the solution is to allow to allow another child of VideoView to create a different instance of BaseMediaController

@szymanskip
Copy link
Contributor

I did something similar with #87
That solution doesn't require you to override VideoView

@lintax
Copy link
Author

lintax commented May 17, 2018

Yes, I've seen that. However you do extra inflate that adds a slowdowns - you first inflate, bind, then unbind and inflate your own version of the control view.
Creating a custom VideoView does not add any runtime cost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants