-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PSBT v2 #8
Merged
Add PSBT v2 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
psbt-v2
branch
2 times, most recently
from
November 30, 2023 05:03
156c438
to
5e11818
Compare
tcharding
force-pushed
the
psbt-v2
branch
3 times, most recently
from
December 13, 2023 01:14
0d5b414
to
ff7dcc6
Compare
Merged
tcharding
force-pushed
the
psbt-v2
branch
3 times, most recently
from
December 13, 2023 01:51
db3f8b7
to
74e5a0e
Compare
In preparation for adding the PSBT v2 implementation, move the keytype consts to a newly created `consts` module.
Add all the consts defined in bip-174, this includes the new ones for psbt v2 as well as one unused one from v0. Include a commented attribute on each to keep clippy quiet.
tcharding
force-pushed
the
psbt-v2
branch
4 times, most recently
from
December 14, 2023 04:36
7f1690f
to
d5ee9d9
Compare
Add an implementation of PSBT version 2 - BOOM! Includes all test vectors from BIP-370. Also includes changes to `v0` to explicitly exclude keys as required by PSBT v2 upgrade.
There is still work to do but I'm merging this now. Example code does a PSBT v2 workflow upto and including siging (using BIP-32 / ECDSA). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an implementation of PSBT version 2 - BOOM!