Do cleanups and fixes #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not have any benchmark code, remove the attribute.
We do not have any fuzz tests, remove the attribute.
I don't care either way and this lint allow references rust-bitcoin, just remove it.
As is conventional in Rust use one level of path qualification for `consensus` functions. Unfortunately we have to use two levels for the error type `consensus::encode::Error` but this is a problem with `rust-bitcoin` not here.
Make all the derives uniform, more-or-less most important thing first and group the eq/ord/hash ones.
tcharding
force-pushed
the
01-09-cleanup
branch
from
cb0f6ac
to
3cc4dd1
Compare
clippy warns of big error variant, box the transactions.
tcharding
force-pushed
the
01-09-cleanup
branch
from
4a8a7b8
to
4122df0
Compare
Add feature gate on "std" to unit tests and the an example.
tcharding
force-pushed
the
01-09-cleanup
branch
from
1459596
to
afa064e
Compare
Some how we were using `cargo clippy` instead of `cargo run` - no clue how this was passing CI before?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something seriously strange is going on, a whole bunch of CI fails popped up but we had a green run on CI before hand???
Do a bunch of trivial cleanups, followed by:
c8f90db Box the transactions in CombineError- adds boxing to error variant types to reduce size.clippyin CIcargo runinstead ofcargo clippyin CI