Add BIP-174 test vectors #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
bip-174-test-vectors
branch
from
716a6b7
to
e0b0471
Compare
|
Hey @DanGould I copied the stuff from |
Add all the test vectors, the parsing stuff is re-written, but the complex stuff in `bip-174.rs` is copied directly from `rust-bitcoin/bitcoin/tests/psbt.rs` where it was written by myself, Dan, and Armin. Co-developed-by: DanGould <[email protected]> Co-developed-by: Armin Sabouri <[email protected]>
tcharding
force-pushed
the
bip-174-test-vectors
branch
from
e0b0471
to
5245faf
Compare
|
Force push adds the signer checks, with a couple of todo's left in there. The code is pretty racy. |
|
I'm sure @0xBEEFCAF3 would understand |
|
All good here! |
|
Legend, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add all the test vectors:
bip-174.rsis copied directly fromrust-bitcoin/bitcoin/tests/psbt.rswhere it was written by myself, Dan, and Armin.rust-bitcoinSee co-developed-by tag for email addresses of the other two devs.