Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade/element web v1.11.53 #887

Merged
merged 301 commits into from
Feb 14, 2024
Merged

Conversation

estellecomment
Copy link
Contributor

@estellecomment estellecomment commented Feb 5, 2024

  • remove patches/Better-text-for-tab-switch if it's not needed any more
  • Change-sections-order-in-security-privacy-settings : some strings fixed ?
  • export-room-members : button probably moved out of the header. Is that ok ?
  • remove-fdroid : check that the fix works now the patch is removed
  • No-voip-mentions-in-onboarding : remove a custom string ?
  • room-summary-card: we're not using the same markup as element. Should we ? Check that RoomSummaryCard is not broken.
  • this :
image
  • this :
image
  • this :
image https://github.com//issues/890
  • Should we offer "Vérifier avec un autre appareil" on login ?

Also :

Note : new warning appears : "start value has mixed support, consider using flex-start instead"
This is a pcss warning. Ex: align-self: start; -> align-self: flex-start;
Ignoring because the worst that can happen is a bit messed up layout.

  • "Labs"/Experimental est affiché dans les settings :
image

renovate bot and others added 30 commits October 18, 2023 17:18
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Telatynski <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Telatynski <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This reverts commit e4d365a.

This is better done through the project board automation, otherwise we risk
moving items out of "In Progress" back to "Qualification".
* document OIDC config

* tidy
Update user name
Once this lands, *existing* sessions will continue to use legacy crypto, but
*new* logins will use rust crypto.
# Conflicts:
#	yarn.lock
@estellecomment estellecomment marked this pull request as ready for review February 9, 2024 10:26
.github/labels.yml Outdated Show resolved Hide resolved
we don't neeed extra labels
@odelcroi odelcroi self-requested a review February 9, 2024 14:23
Copy link
Member

@odelcroi odelcroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@odelcroi odelcroi self-requested a review February 9, 2024 14:28
@odelcroi
Copy link
Member

odelcroi commented Feb 9, 2024

I found a blocking bug :
Go to parameters>about : panel closes with console error. It is blocking because users can not access to their tchap about version
Capture d’écran 2024-02-09 à 15 26 15

Copy link
Member

@odelcroi odelcroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking bug found, see comments

@estellecomment
Copy link
Contributor Author

Bug : "Labs"/Experimental est affiché dans les settings :
image

(yavait pas un e2e test qui le checkait ??)

@odelcroi
Copy link
Member

Bug : "Labs"/Experimental est affiché dans les settings : image

(yavait pas un e2e test qui le checkait ??)

Je ne le vois pas dans la review app, où l'as tu vu? Sinon on merge et on fixe après, ca semble pas bloquant

@odelcroi odelcroi merged commit 263c934 into develop_tchap Feb 14, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.