TCHAP: fix lint and tests issues

README_tchap.md

@@ -1,23 +1,23 @@
 ## Config variable
 
--   tchap_features : Object containing the feature that can be activated by homeserver
-    -   "feature_email_notification": Email notification
-    -   "feature_space": Creation of spaces
-    -   "feature_thread": Activate thread on messages
-    -   "feature_audio_call": Activate 1 to 1 voice call
-    -   "feature_video_call": Activate 1 to 1 video call
-    -   "feature_video_group_call": Activate group call on rooms, for this feature to work, the values of `UIFeature.widgets` and `feature_group_calls` needs to be true
-    -   "feature_screenshare_call": Activate 1 to 1 screenshare
--   "tchap_sso_flow"
-    -   "isActive": Activate ProConnect SSO flow
+- tchap_features : Object containing the feature that can be activated by homeserver
+    - "feature_email_notification": Email notification
+    - "feature_space": Creation of spaces
+    - "feature_thread": Activate thread on messages
+    - "feature_audio_call": Activate 1 to 1 voice call
+    - "feature_video_call": Activate 1 to 1 video call
+    - "feature_video_group_call": Activate group call on rooms, for this feature to work, the values of `UIFeature.widgets` and `feature_group_calls` needs to be true
+    - "feature_screenshare_call": Activate 1 to 1 screenshare
+- "tchap_sso_flow"
+    - "isActive": Activate ProConnect SSO flow
 
 ## File structures
 
--   modules -> used for translation
--   yarn-linked-dependencies -> legacy dependencies used for matrix-js-sdk
--   patches_legacy -> legacy patches directory in which code for the patches where put
--   patches -> used for matrix-js-sdk patches
--   src -> code containing ex matrix-react-sdk lib and element-web code
+- modules -> used for translation
+- yarn-linked-dependencies -> legacy dependencies used for matrix-js-sdk
+- patches_legacy -> legacy patches directory in which code for the patches where put
+- patches -> used for matrix-js-sdk patches
+- src -> code containing ex matrix-react-sdk lib and element-web code
 
 ## Local dev installation
 
@@ -31,8 +31,8 @@ yarn start
 
 ### Making a change
 
--   In element code :
-    You need to add around your code those comments
+- In element code :
+  You need to add around your code those comments
 
 ```
 // :TCHAP: NAME_OF_THE_PATCH
@@ -44,5 +44,5 @@ Then also update the `subtree-modifications.json` file. We continue to keep trac
 
 ### Tests
 
--   Now that `matrix-react-sdk` is merged inside tchap-web, we only target the `test/tchap` folder in order to run our tests on only the files that tchap has modified.
--   For every modification, we need to copy the existing test (if there is one) of the component, move it to tchap folder and modify it accordingly.
+- Now that `matrix-react-sdk` is merged inside tchap-web, we only target the `test/tchap` folder in order to run our tests on only the files that tchap has modified.
+- For every modification, we need to copy the existing test (if there is one) of the component, move it to tchap folder and modify it accordingly.

cypress/README.md

@@ -1,12 +1,12 @@
 # How to run cypress tests locally
 
--   run a local instance of tchap-web in your environment
+- run a local instance of tchap-web in your environment
 
 ```
 yarn start
 ```
 
--   run cypress
+- run cypress
 
 Make a .env file, by coying .env.example. Set values for the `E2E_TEST_*` variables. Tests will run on your localhost, so make sure the test user exists in the backend called by localhost.
 

modules/tchap-translations/README.md

@@ -2,11 +2,11 @@
 
 ## What are all these translation files ?
 
--   `tchap_translations.json` : translations for strings that Tchap code adds to the web and react-sdk repos.
+- `tchap_translations.json` : translations for strings that Tchap code adds to the web and react-sdk repos.
 
--   `tchap_translations_removed.json` : strings that tchap modifications have removed from element code. They are listed explicitly because otherwise the translation-checking script will fail (see below).
+- `tchap_translations_removed.json` : strings that tchap modifications have removed from element code. They are listed explicitly because otherwise the translation-checking script will fail (see below).
 
--   `old/tchap_translations_lost.json` : translations that were present in previous versions, but that don't correspond to any existing code now. Many correspond to customisations made in tchap-web v2. Keeping them around in case they're useful.
+- `old/tchap_translations_lost.json` : translations that were present in previous versions, but that don't correspond to any existing code now. Many correspond to customisations made in tchap-web v2. Keeping them around in case they're useful.
 
 ## The translation-checking script
 

test/unit-tests/tchap/components/views/settings/AccountUserSettingsTab-test.tsx

@@ -16,7 +16,6 @@ import {
     mockClientMethodsUser,
     mockPlatformPeg,
 } from "~tchap-web/test/test-utils";
-import { useId } from "~tchap-web/src/utils/useId";
 
 jest.mock(
     "~tchap-web/src/components/views/settings/ChangePassword",
@@ -26,8 +25,6 @@ jest.mock(
         },
 );
 
-jest.mock("~tchap-web/src/utils/useId");
-
 describe("<AccountUserSettingsTab />", () => {
     const defaultProps = {
         closeSettingsFn: jest.fn(),
@@ -79,8 +76,6 @@ describe("<AccountUserSettingsTab />", () => {
             (settingName: string) => settingName === UIFeature.Deactivate,
         );
 
-        // labelled id on username is autogeneraed, we fix it so that snapshot is always the same
-        mocked(useId).mockImplementation(() => "1234");
     });
 
     afterEach(() => {

test/unit-tests/tchap/components/views/settings/__snapshots__/AccountUserSettingsTab-test.tsx.snap

@@ -57,7 +57,7 @@ exports[`<AccountUserSettingsTab /> common view snapshot should render section w
                 >
                   <label
                     class="_label_ssths_67"
-                    for="radix-:r0:"
+                    for="radix-:r1:"
                   >
                     Display Name
                   </label>
@@ -67,7 +67,7 @@ exports[`<AccountUserSettingsTab /> common view snapshot should render section w
                     <input
                       class="_control_9gon8_18"
                       disabled=""
-                      id="radix-:r0:"
+                      id="radix-:r1:"
                       name="input"
                       title=""
                       value=""
@@ -81,12 +81,12 @@ exports[`<AccountUserSettingsTab /> common view snapshot should render section w
             >
               <div
                 class="mx_UserProfileSettings_profile_controls_userId_label"
-                id="1234"
+                id=":r2:"
               >
                 Username
               </div>
               <div
-                aria-labelledby="1234"
+                aria-labelledby=":r2:"
                 class="mx_CopyableText mx_CopyableText_border"
               >
                 @alice:server.org

test/unit-tests/tchap/stores/RoomViewStore-test.ts

@@ -9,7 +9,6 @@ import { SlidingSyncManager } from "~tchap-web/src/SlidingSyncManager";
 import { PosthogAnalytics } from "~tchap-web/src/PosthogAnalytics";
 import { MatrixDispatcher } from "~tchap-web/src/dispatcher/dispatcher";
 import { SpaceStoreClass } from "~tchap-web/src/stores/spaces/SpaceStore";
-import { VoiceBroadcastPlaybacksStore } from "~tchap-web/src/voice-broadcast";
 import Modal from "~tchap-web/src/Modal";
 import ExternalAccountHandler from "~tchap-web/src/tchap/lib/ExternalAccountHandler";
 import { _t } from "~tchap-web/src/languageHandler";
@@ -95,7 +94,6 @@ describe("RoomViewStore", function () {
         stores._SlidingSyncManager = slidingSyncManager;
         stores._PosthogAnalytics = new MockPosthogAnalytics();
         stores._SpaceStore = new MockSpaceStore();
-        stores._VoiceBroadcastPlaybacksStore = new VoiceBroadcastPlaybacksStore(stores.voiceBroadcastRecordingsStore);
         roomViewStore = new RoomViewStore(dis, stores);
         stores._RoomViewStore = roomViewStore;