Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VoIP bug report type #1010

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Add VoIP bug report type #1010

merged 4 commits into from
Feb 7, 2024

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Feb 5, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

tchapgouv/tchap-product#267

Motivation and context

Screenshots / GIFs

image

Tests

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@yostyle yostyle requested a review from NicolasBuquet February 5, 2024 23:34
@yostyle yostyle self-assigned this Feb 5, 2024
@tchap-danger-bot
Copy link

Warnings
⚠️

Please add a changelog. See instructions here

Generated by 🚫 dangerJS against 0203662

@yostyle yostyle marked this pull request as ready for review February 6, 2024 00:02
Copy link
Contributor

@NicolasBuquet NicolasBuquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dans la partie "audio_input", je préfère que la propriété soit toujours présente.
Avec des valeurs différentes suivant les cas, mais qu'elle fasse toujours partie du payload.

@tchap-danger-bot
Copy link

Warnings
⚠️ Please add a reviewer to your PR.

Generated by 🚫 dangerJS against b5309c1

@yostyle yostyle requested a review from NicolasBuquet February 7, 2024 09:35
Copy link
Contributor

@NicolasBuquet NicolasBuquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yostyle yostyle merged commit df4d028 into develop Feb 7, 2024
17 of 18 checks passed
@yostyle yostyle deleted the yostyle/feedback_voip branch February 7, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants