Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean parsing is broken with Postgres #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

backspace
Copy link
Contributor

I’m not opening this to actually be merged, just to highlight the problem. I found that I couldn’t get a true value from a boolean field and it seems like a difference between what’s returned from the in-memory SQLite database in tests vs Postgres.

It’s possible the Boolean(value) change is sufficient but there’s a lot of ceremony here just to get tests running on CI with Postgres, I don’t know that it’s worth having it all, or if it is, it would need to be completed.

  • it was using UUIDs and failing because the hard-coded IDs were invalid
  • my attempt at overriding generateId failed
  • so I limited it to run one test and changed the setup data to use UUIDs

I showed it failing when I added a boolean to the schema and made its value true in the example author. Then it passed with the change to boolean handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant