Import and modernize bocoup/test262-regexp-generator #4303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 2, 2024
|
Unfortunately, |
ptomato
force-pushed
the
bocoup-test262-regexp-generator
branch
from
90388c6
to
3b31f3c
Compare
mathiasbynens
approved these changes
Nov 2, 2024
Ms2ger
approved these changes
Nov 4, 2024
ptomato
force-pushed
the
bocoup-test262-regexp-generator
branch
8 times, most recently
from
19da29a
to
31ddf4f
Compare
|
Rather than mess with the Circle-CI images to get one that has both Python and Node installed, I'll migrate the linter and test generation jobs to GitHub Actions where they can run on the (Context: the |
Instead of an output/ folder, output the tests directly into the folder where they live.
Add some minimal instructions for regenerating the tests.
This code hasn't been touched in a while, so it's probably good to bring in the newest versions of the dependencies. We can easily tell if there was any incompatible effect on the output. The latest version of filenamify requires using ES modules. We also have to adapt to a breaking change in regexpu-core (see mathiasbynens/regexpu-core#49). Also convert the dependencies to devDependencies, since this tool is not necessary for executing test262.
The optimizations from commit e558b29 were never incorporated into the upstream test generator. This does so now. As far as I can tell, the changes to the Unicode ranges are purely cosmetic. Some are formatted as 6-digit hex numbers instead of 4-digit. Others move the low-surrogates range 0xDC00-0xDCFF to the beginning of the array, but the union of the ranges is still the same.
These are unused parameters and variables, and all have no effect on the output.
Add the `generated` flag, and update the link to the generator script.
This is necessary so that updates to the tests without corresponding updates to the generator script will be flagged in CI runs.
As per the package.json docs, these are optional if the package is not being published.
While we're touching this we may as well update the quote from ECMA-262 to match what it currently says.
Our config files specify two-space indents for JS files. These scripts were probably written before that was a thing. Update the indentation of the script and the generated tests all in one go.
We have .mjs files now in the regexp-generator tool. Extend the same indentation from .js files to cover them as well.
ptomato
force-pushed
the
bocoup-test262-regexp-generator
branch
from
31ddf4f
to
8c40991
Compare
|
With CI set up to handle npm dependencies, I've rebased this and will land it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/bocoup/test262-regexp-generator was used to generate the tests in
test/built-ins/RegExp/CharacterClassEscapes/. It makes sense for this script to live in the same repo as the tests it generates. Especially since in the meantime, the tests themselves have gotten out of sync with the upstream.This imports the script, modernizes and cleans up the code, implements the changes necessary to match the changes made in the meantime to the tests, and integrates the script into the build process.