Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a decoding algorithm for index maps #132

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add a decoding algorithm for index maps #132

wants to merge 9 commits into from

Commits on Nov 8, 2024

  1. Add a decoding algorithm for index maps

    @takikawa
    takikawa committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    5f9d131 View commit details
    Browse the repository at this point in the history

  2. Index map algorithm: fix generatedColumn on lines after the first

    @takikawa
    takikawa committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    079cc65 View commit details
    Browse the repository at this point in the history

  3. Fix uses of "extend" (it's in-place not functional)

    @takikawa
    takikawa committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    410d986 View commit details
    Browse the repository at this point in the history

  4. Address feedback about column offset

    @takikawa
    takikawa committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    c5b47be View commit details
    Browse the repository at this point in the history

  5. Use set union instead of list extend

    @takikawa
    takikawa committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    fd1bf64 View commit details
    Browse the repository at this point in the history

  6. Editorial: avoid warnings by removing dfns for index map 

    These aren't linked to so they don't need the tags
    @takikawa
    takikawa committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    477426d View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Address more PR feedback 

      * Fix first line issue
  * Use extend again for new mappings
    @takikawa
    takikawa committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    ee0f9b0 View commit details
    Browse the repository at this point in the history

  2. Refactor the overlap check 

      * Check the overlap of ranges {lastFirst, lastPrev} and the
    {first, last} of the current source map section instead of
    current more complicated steps.
  * The overlap check also ensures the order of the ranges, beyond
    the ordering of the offsets (which itself doesn't guarantee
    range order)
  * Some editorial changes for the check
    @takikawa
    takikawa committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    9687241 View commit details
    Browse the repository at this point in the history

  3. Change offset checks to "integral Number" 

    Also set a default value so the algorithm continues
    @takikawa
    takikawa committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    9505a3d View commit details
    Browse the repository at this point in the history