Editorial: OrdinaryDefineOwnProperty can't throw for ordinary objects and arrays #3403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anba
force-pushed
the
infallible-ordinary-define-own-prop
branch
from
6b1a2b5
to
53123e3
Compare
… and arrays `OrdinaryDefineOwnProperty` can return an abrupt completion if either `O.[[GetOwnProperty]]` or `IsExtensible(O)` returns an abrupt completion. When `O` is an ordinary object or an array, neither `O.[[GetOwnProperty]]` nor `IsExtensible(O)` can return an abrupt completion, therefore `OrdinaryDefineOwnProperty` is infallible.
anba
force-pushed
the
infallible-ordinary-define-own-prop
branch
from
53123e3
to
72e160c
Compare
| @@ -12671,14 +12671,14 @@ <h1> | |||
| [[DefineOwnProperty]] ( | |||
| _P_: a property key, | |||
| _Desc_: a Property Descriptor, | |||
| ): either a normal completion containing a Boolean or a throw completion | |||
| ): a Boolean | |||
There was a problem hiding this comment.
Suggested change
| ): a Boolean | |
| ): a normal completion containing a Boolean |
We don't have tooling to enforce it, but we don't allow internal methods to have mixed signatures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OrdinaryDefineOwnPropertycan return an abrupt completion if eitherO.[[GetOwnProperty]]orIsExtensible(O)returns an abrupt completion. WhenOis an ordinary object or an array, neitherO.[[GetOwnProperty]]norIsExtensible(O)can return an abrupt completion, thereforeOrdinaryDefineOwnPropertyis infallible.