add jsdoc #45
Open
add jsdoc #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbo47
force-pushed
the
jsdoc
branch
2 times, most recently
from
1897664
to
dcc429f
Compare
aloisklink
requested changes
Oct 7, 2024
There was a problem hiding this comment.
8740b83 looks good to me!
Although 83d5efe has errors in it, e.g. a label is confusingly not string, but an object. We could copy the types from https://www.npmjs.com/package/@types/dagre (and the other packages) into this code-base. I believe they're also all under the MIT license, so can legally use it, we'd just need to add even more copyright headers to LICENSE.md file!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.