build: fix TypeScript prepack command
#38
Conversation
Fix the TypeScript `npm run generate_types` command by: - Only deleting files in the `src/` dir, not in the `node_modules` dir - Skipping building the types from `.test.js` files - Fixing some type errors caused by the Lodash replacement PR
|
Thank you @aloisklink Currently the project is not publishing types. So I think people are relying on these projects for types: When I tried to migrate to typescript, we realized that there is minor discrepancies between what is generated by the code and these projects. See #28 I'm worried publishing the types is going to have side effects for people. Thoughts? Maybe we can publish the types ni different projects, like |
I think we are publishing the auto-generated types from the I had a look at https://arethetypeswrong.github.io/, and every single version of
If we remove them, that would cause side-effects for people.
😢 I'm guessing that's because most of this code is written in a very very old style of JavaScript, that nobody uses nowadays. As a temporary measure, we can use JSDoc comments in |
Fix the TypeScript
npm run generate_typescommand by:src/dir, not in thenode_modulesdir.test.jsfilesI've also reverted the TypeScript ES2020 version that was used before e03371f, since we're not using any ES2022 features, and if we do start using them, I'm worried it might be a breaking change for users.