Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update libs #35

Merged
merged 3 commits into from
Sep 12, 2024
Merged

update libs #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05b8b11
update libs
Sep 12, 2024
277a822
remove prettier
Sep 12, 2024
cc42ee1
remove type generation
Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x]
node-version: [20.x]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My opinion is to keep on testing with Node.JS v18, until D3 drops support for Node.JS v18 (I'm guessing this would maybe with a future D3 v8 or v9 release).

Suggested change
node-version: [20.x]
node-version: [18.x, 20.x]

GitHub Actions is free for open-source projects, so we can run everything twice without any issues.

# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
steps:
- uses: actions/checkout@v3
Expand All @@ -21,8 +21,8 @@ jobs:
- run: npm ci # throws an error if the package-lock.json file is out of sync
- name: Check for linting errors (run `npm run lint:fix` to fix)
run: npm run lint
- name: Check for prettier errors (run `npm run format` to fix)
run: npx prettier --check .
# - name: Check for prettier errors (run `npm run format` to fix)
# run: npx prettier --check .
Comment on lines +24 to +25
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, you should be able to re-enable this after you run npm run format and commit the changes.

(It's basically just adding a trailing comma to everything: https://prettier.io/blog/2023/07/05/3.0.0.html#javascript)

- name: Run unit tests
run: npm test
- name: Build the npm package to publish
Expand Down
Loading
Loading