Add Requirements and edit README #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the usability improvement pull request. I'm happy to accept this if you can change the version requirements to be minimum version numbers where possible (e.g. torch>=0.4.0). |
DaHaiHuha
approved these changes
Dec 30, 2019
DaHaiHuha
reviewed
Dec 31, 2019
| @@ -0,0 +1,8 @@ | |||
| torch==1.3.0 | |||
There was a problem hiding this comment.
A specific API in 1.3 version would broke the training process. Maybe you should change it to 0.4=<torch=<1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit the README for installation instructions and add requirements.txt to the repo