Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Update pypa/gh-action-pypi-publish action to v1.12.2 #347

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 5, 2024

This PR contains the following updates:

Package Type Update Change
pypa/gh-action-pypi-publish action minor v1.10.3 -> v1.12.2

Release Notes

pypa/gh-action-pypi-publish (pypa/gh-action-pypi-publish)

v1.12.2

Compare Source

🐛 What's Fixed

The fix for signing legacy zip sdists turned out to be incomplete, so @​woodruffw💰 promptly produced another follow-up that updated pypi-attestations from v0.0.13 to v0.0.15 in #​297. This is the only change since the previous release.

🪞 Full Diff: pypa/gh-action-pypi-publish@v1.12.1...v1.12.2

🧔‍♂️ Release Manager: @​webknjaz 🇺🇦

v1.12.1

Compare Source

🐛 What's Fixed

Version v1.12.0 hit several rare corner cases we never considered fully supported, and this release fixes a few of those.
In #​294, @​webknjaz💰 improved the self-hosted runner experience by pre-installing Python if it's not there, and with #​293 the ability to use the action on GitHub Enterprise instances has been restored. The latter should've also fixed the ability to invoke [pypi-publish][pypi-publish] from nested in-repo composite actions — another exotic use-case that was never tested in our CI.
@​woodruffw💰 also managed to squeeze in a last-minute fix for detecting legacy .zip sdists while producing attestations via #​295.

🪞 Full Diff: pypa/gh-action-pypi-publish@v1.12.0...v1.12.1

🧔‍♂️ Release Manager: @​webknjaz 🇺🇦

🙏 Huge Thanks to all the bug reporters for posting the logs, helping inspect the problems and verify the regression fixes!

v1.12.0

Compare Source

⚡️ Why Should You Update?

This is a minor version bump, but it does not add any new user-facing interfaces. Still, I felt like it should not be a patch-release: this update brings significant changes to the action invocation and internal release process.

Previously, each invocation of [pypi-publish][pypi-publish] required building a container image in the invoking CI job. This was inefficient and added about 30 seconds to the publishing jobs at their startup just to build the container.

I wanted to improve this for over three years (#​58) and a little over half a year ago @​br3ndonland💰 stepped up and offered a very comprehensive solution to the limitation I was hoping to overcome: #​230.

Going forward, I'm going to pre-build per-version containers prior to cutting each release. And the action invocations will just pull the image from GitHub Container registry.

[!CAUTION]
Known quirks:

  • This seems to not work on self-hosted runners without a python executable: #​289. The workaround could be installing it prior to running the action.
  • ~Pinning to commit hashes does not work: #​290. Workaround: postpone updating until it's fixed or switch to Git tags for now. Subscribe to that issue to follow the progress.~ UPD: This was an issue during the first 12 hours post release and it has been addressed upstream by publishing a commit SHA-tagged image for the release on Nov 12, 2024 at 10:27 UTC+1.
  • Calling pypi-publish from another nested repo-local composite action might be breaking file paths: #​291. Workaround: postpone updating until it's fixed. Subscribe to that issue to follow the progress.
  • Running within GitHub Enterprise fails on the action repo clone: #​292. Workaround: postpone updating until it's fixed. Subscribe to that issue to follow the progress.

🪞 Full Diff: pypa/gh-action-pypi-publish@v1.11.0...v1.12.0

🧔‍♂️ Release Manager: @​webknjaz 🇺🇦

v1.11.0

Compare Source

🔏 Helping you become a trusted supply chain link 🔗

Two months ago, in v1.10.0, @​woodruffw💰 integrated support for generating and uploading PEP 740 digital attestations that can be used as provenance objects when analyzing dependency chains for the integrity.

To make sure it works well, it was implemented as an opt-in, so a relatively small subset of projects was able to try it out, and a few issues have been determined and fixed during this time.

That changes today! This version changes the feature toggle to “on by default”. This means that from now on, every project making use of Trusted Publishing will start producing and publishing digital attestations without having to do any modifications to how they use this action.

@​woodruffw💰 flipped the respective toggle in #​277 with the possibility to opt-out.

🛠️ Internal Dependencies

@​woodruffw💰 bumped sigstore to v3.5.1 and pypi-attestations to v0.0.13 in lock files via #​276.

🪞 Full Diff: pypa/gh-action-pypi-publish@v1.10.3...v1.11.0

🧔‍♂️ Release Manager: @​webknjaz 🇺🇦

🙏 Special Thanks to William for working on improving the supply chain provenance in the ecosystem! The overall effort is tracked @&#https://github.com/pypi/warehouse/issues/15871/15871.


Configuration

📅 Schedule: Branch creation - "* 2 1 * *" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added auto Marks a PR or issue that has been created automatically. dependencies Upgrade or downgrade of project dependencies. github_actions no-stale This issue or PR is exempted from the stale bot. labels Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.84%. Comparing base (5b1f93c) to head (647b5b0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #347   +/-   ##
=======================================
  Coverage   97.84%   97.84%           
=======================================
  Files          34       34           
  Lines        1484     1484           
  Branches       83       83           
=======================================
  Hits         1452     1452           
  Misses         18       18           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot force-pushed the renovate/pypa-gh-action-pypi-publish-1.x branch from d417751 to 647b5b0 Compare December 5, 2024 21:03
@tb1337 tb1337 merged commit d22c11b into main Dec 5, 2024
@tb1337 tb1337 deleted the renovate/pypa-gh-action-pypi-publish-1.x branch December 5, 2024 21:03
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto Marks a PR or issue that has been created automatically. dependencies Upgrade or downgrade of project dependencies. github_actions no-stale This issue or PR is exempted from the stale bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant