fix: always process all events in the queue on x11. (#73)

* Always process all events in the queue on x11. Previously, there was always a 50ms delay between processing individual events, which could lead to a queue of events building up if the key repeat was higher than 20 Hz. This resulted in the global hotkey release only being detected long after the key is released. * change file --------- Co-authored-by: Amr Bashir <[email protected]>
tauri-apps · Apr 22, 2024 · 24f41b0 · 24f41b0
1 parent 9af0a80
commit 24f41b0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.changes/x11-pending-events-buildup.md b/.changes/x11-pending-events-buildup.md
@@ -0,0 +1,5 @@
+---
+"global-hotkey": patch
+---
+
+Always service all pending events to avoid a queue of events from building up.
diff --git a/src/platform_impl/x11/mod.rs b/src/platform_impl/x11/mod.rs
@@ -199,7 +199,8 @@ fn events_processor(thread_rx: Receiver<ThreadMessage>) {
             let mut event: xlib::XEvent = std::mem::zeroed();
 
             loop {
-                if (xlib.XPending)(display) > 0 {
+                // Always service all pending events to avoid a queue of events from building up.
+                while (xlib.XPending)(display) > 0 {
                     (xlib.XNextEvent)(display, &mut event);
                     match event.get_type() {
                         e @ xlib::KeyPress | e @ xlib::KeyRelease => {