Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node to wikitext #306

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Node to wikitext #306

merged 4 commits into from
Sep 16, 2024

Conversation

kristian-clausal
Copy link
Collaborator

When parsing lists, Wtp.node_to_wikitext will not reverse the transformation correctly:

# line 1
## line 2
#: example 1
#: example 2

becomes:

# line 1
## line 2
#:#: example 1
#: example 2

This seems like the result of a really old kludge that seems unnecessary now. I think WikiNode has changed between now-and-then, and the prefix of the line might have been explicitly added to only later so the old code wasn't update and there was an extra kludge inserting "#"+":" when two lists were next to each other (as in when you have a line starting with "#" followed by ":", for example; same depth, different lists).

@kristian-clausal kristian-clausal merged commit 1e6c2e2 into main Sep 16, 2024
10 checks passed
@kristian-clausal kristian-clausal deleted the node-to-wikitext branch September 16, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant