New methods: get and refresh #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
text query has been deprecated in elasticsearch 0.90 and removed in elasticsearch 1.0. match query should be used instead. elastic/elasticsearch#4033
Documentation for elasticsearch's refresh API can be found at:
http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/indices-refresh.html
MultipleIndexQueryTestCase's delete_index always used self.index instead of relying on the index name passed by parameter.
This way we only wait the necessary amount of time for documents to be loaded into elasticsearch. I kept timeout = 5 as a default in order to keep backwards compatibility. On a new major version, where that's not a concern, I think we should drop timeout entirely.
While creating tests for create_index I found a bug on MultipleIndexesQueryTestCase. I'm fixing it in this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added elasticsearch's refresh and get methods. I think refresh may take the place of timeout. I kept timeout working how it was for backwards compatibility, but if timeout is set to None, then refresh is used.
I have also added support for creating aliases on MultipleIndexesQueryTestCase.