Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update websockets, add autoreconnect #180

Merged
merged 2 commits into from
Dec 9, 2024
Merged

update websockets, add autoreconnect #180

merged 2 commits into from
Dec 9, 2024

Conversation

Graeme22
Copy link
Contributor

@Graeme22 Graeme22 commented Dec 4, 2024

Description

This PR updates the websockets used in the alert and data streamers to the updated asyncio websockets present from websockets==13.1 and onwards. These replace the legacy websocket code from before. Additionally, the websocket will automatically try to reconnect upon certain connection errors with an exponential backoff algorithm.

Pre-merge checklist

  • Code formatted correctly (check with make lint)
  • Code implemented for both sync and async
  • Passing tests locally (check with make test, make sure you have TT_USERNAME, TT_PASSWORD, and TT_ACCOUNT environment variables set)
  • New tests added (if applicable)

Please note that, in order to pass the tests, you'll need to set up your Tastytrade credentials as repository secrets on your local fork. Read more at CONTRIBUTING.md.

@Graeme22 Graeme22 merged commit 6b0506b into master Dec 9, 2024
1 check failed
@Graeme22 Graeme22 deleted the websocket-upgrade branch December 9, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant