Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better typing for streamer, orders #170

Merged
merged 4 commits into from
Oct 10, 2024
Merged

better typing for streamer, orders #170

merged 4 commits into from
Oct 10, 2024

Conversation

Graeme22
Copy link
Contributor

@Graeme22 Graeme22 commented Oct 10, 2024

Description

Improves typing for orders and complex orders, where union types make things very unpleasant at times.
Improves typing for alert and data streamers, so that types are correct when using listen, get_event, etc.

Pre-merge checklist

  • Code formatted correctly (check with make lint)
  • Code implemented for both sync and async
  • Passing tests locally (check with make test, make sure you have TT_USERNAME, TT_PASSWORD, and TT_ACCOUNT environment variables set)
  • New tests added (if applicable)

Please note that, in order to pass the tests, you'll need to set up your Tastytrade credentials as repository secrets on your local fork. Read more at CONTRIBUTING.md.

@Graeme22 Graeme22 merged commit 2c903c6 into master Oct 10, 2024
1 check passed
@Graeme22 Graeme22 deleted the better-types branch October 10, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant