Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo on json account node name #39

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

4th-turning
Copy link
Contributor

tastytradeClient.accountsAndCustomersService.getCustomerAccounts() returns below json, so docs contains typo:

accounts[0].accounts['account-number'] should be accounts[0].account['account-number']

[
    {
        "account": {
            "account-number": "XXXX",
            "external-id": "AXXXX",
            "opened-at": "2021-01-01T15:54:10.440+00:00",
            "nickname": "IRA",
            "account-type-name": "Traditional IRA",
            "day-trader-status": false,
            "ext-crm-id": "aaaa",
            "is-closed": false,
            "is-firm-error": false,
            "is-firm-proprietary": false,
            "is-futures-approved": true,
            "is-test-drive": false,
            "margin-or-cash": "Cash",
            "is-foreign": false,
            "funding-date": "2024-03-21",
            "investment-objective": "SPECULATION",
            "futures-account-purpose": "SPECULATING",
            "suitable-options-level": "Defined Risk Spreads Plus Naked",
            "created-at": "2021-01-01T15:54:10.447+00:00"
        },
        "authority-level": "owner"
    },
    {
        "account": {
            "account-number": "5XXXXX",
            "external-id": "AXXXXX",
            "opened-at": "2021-11-25T13:29:50.726+00:00",
            "nickname": "Margin",
            "account-type-name": "Individual",
            "day-trader-status": false,
            "ext-crm-id": "aaaa",
            "is-closed": false,
            "is-firm-error": false,
            "is-firm-proprietary": false,
            "is-futures-approved": true,
            "is-test-drive": false,
            "margin-or-cash": "Margin",
            "is-foreign": false,
            "funding-date": "2023-10-26",
            "investment-objective": "SPECULATION",
            "futures-account-purpose": "SPECULATING",
            "suitable-options-level": "No Restrictions",
            "created-at": "2021-11-25T13:29:50.732+00:00"
        },
        "authority-level": "owner"
    }
]

@4th-turning 4th-turning requested a review from dmoss18 as a code owner April 10, 2024 03:02
@dmoss18 dmoss18 merged commit 57153c9 into tastytrade:master Apr 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants