Catch any errors when instantiating https.Agent #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osdevisnot
reviewed
Feb 13, 2024
|
@osdevisnot I took it out completely. Let me know if you see any more warnings. If it looks good, I'll merge this and publish a new version. |
|
Amazing, this works better now. I would recommend we merge it, but wait to cut a new version after #25 is resolved. |
osdevisnot
approved these changes
Feb 15, 2024
dmoss18
force-pushed
the
https-browser-fix
branch
from
64facea to
9513dde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18
Browsers should adhere to the 1.2 minimum TLS version, so we'll just catch any errors with this and move on.