-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: non-blocking tasks #128
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #128 +/- ##
===========================================
+ Coverage 67.62% 72.60% +4.98%
===========================================
Files 37 43 +6
Lines 942 1387 +445
===========================================
+ Hits 637 1007 +370
- Misses 305 380 +75
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@s3rius are there plans to have this merged / or implemented differently? We have a use-case as well that triggers this that we noticed since we have now implemented the max_async_tasks option. We will "workarround" by separating them into two different workers for now. |
There are plans to implement it differently. There were some attempts. The main idea of another approach is to not give just a sleep function, but an ability to decrease counter of running tasks by the time of executing a function. I've created an issue for that problem here: #258. The problem with this approach is that in most cases we don't use sleep directly, but awaiting something. |
Hello, @s3rius. Pls take a look at the new implementation |
@s3rius A friendly reminder to check this PR :D |
Hello there @s3rius! Pls give it a try =) |
non-blocking sleep through a temporary increase in the number of running tasks on demand of the user.
here is some use cases
max_async_tasks
. Example in tests withmax_async_tasks = 1