Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to TypeScript #11

Closed
wants to merge 3 commits into from
Closed

Move to TypeScript #11

wants to merge 3 commits into from

Conversation

wbhob
Copy link

@wbhob wbhob commented Oct 10, 2017

Fixes #10 by using TypeScript. Typings are automatically generated. I have updated the doc and test commands as well to reflect this.

wbhob added 3 commits October 10, 2017 17:33
sorry they don't look the same, typedoc is in early stages
@tarunbatra
Copy link
Owner

I didn't realize the issue #10 would need a rewrite to solve and I'm not really sure if the issue it worth it. Plus, I really want to avoid build tools, because it's a slippery slope. So, I'd have to reject this PR.

Thanks @wbhob for your effort! I appreciate that.

@tarunbatra tarunbatra closed this Oct 11, 2017
@wbhob
Copy link
Author

wbhob commented Oct 11, 2017

I can also add regular typings, but it's more consistent when using TypeScript itself. I may PR again with regular typings, but they would have to be periodically updated with the library

@tarunbatra
Copy link
Owner

Can you provide a snippet of how it would look like? We can do this if it isn't too tough to keep them updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants