Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no typescript support #10

Closed
nadavten opened this issue Aug 10, 2017 · 7 comments
Closed

no typescript support #10

nadavten opened this issue Aug 10, 2017 · 7 comments

Comments

@nadavten
Copy link

No description provided.

@tarunbatra
Copy link
Owner

Hey @nadavten, thanks for taking the time. Can you elaborate on what do you mean?

@nadavten
Copy link
Author

missings types (@types) for typescript. no intellisence

@tarunbatra
Copy link
Owner

A good feature to have! But I won't be able to add that, as I'm not much aware of Typescript / VSCode.
Keeping the issue open, in case someone would want to submit a PR for this feature.

@wbhob
Copy link

wbhob commented Oct 10, 2017

I will rise to the occasion! If it's ok with you @tarunbatra , I will rewrite in TypeScript, and include build and test scripts. It's very similar to other Object oriented languages, and instead of appending to the prototype, it will simply be a property on a class. PR coming shortly.

@wbhob
Copy link

wbhob commented Oct 10, 2017

Done!

@wbhob
Copy link

wbhob commented Oct 11, 2017

Done (again!)

@tarunbatra
Copy link
Owner

VScode is able to show methods available, their signature and description using JsDoc. This has inspired Issue #13. Closing this issue, hence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants