Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same fmt config as mirage projects #219

Closed
wants to merge 1 commit into from
Closed

Conversation

samoht
Copy link
Collaborator

@samoht samoht commented Oct 22, 2021

As discussed here: ocaml-ppx/ocamlformat#1851

@Leonidas-from-XIV
Copy link
Member

I agree that these formattings make the code easier to read (especially the odd way of formatting longer |> chains by default looks bizarre enough that I don't mind the expansion of Cmdliner declarations over multiple lines in return).

Parts of these settings are in the 0.20 release of OCamlformat, as seen in #211. I would personally prefer to stay with the "conventional" profile and make that more, well, conventional upstream instead of trying to chase down the perfect set of formatting options (that also appear, disappear and change between releases, given there's no 1.x yet). My previous experience with having our companies own set of "blessed options" was that we often ended up stuck behind the newest ocamlformat release because nobody felt like taking up the fight on what to change the options to for new ocamlformat versions.

@NathanReb
Copy link
Contributor

Yup, agree. I think we'll stick to the conventional profile. If these options make it upstream into the profile and it changes the formatting it's fine but I won't start using custom options, especially since I'm an advocate for a config less ocamlformat!

@NathanReb NathanReb closed this Oct 22, 2021
@samoht
Copy link
Collaborator Author

samoht commented Oct 22, 2021

If these options make it upstream into the profile

Having more projects using the same options is also a good argument for changing the default profile. Anyway, I see your point and will keep the "I agree that these formattings make the code easier to read" as an argument to push forward my quest to a more conventional conventional profile :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants