Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between issue comments and PR comments #38

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

gpetiot
Copy link
Member

@gpetiot gpetiot commented Apr 3, 2024

No description provided.

CHANGES.md Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@gpetiot gpetiot merged commit df5f08c into tarides:main Apr 3, 2024
2 of 3 checks passed
@gpetiot gpetiot deleted the issue-pr-comments branch April 3, 2024 15:00
gpetiot added a commit to gpetiot/tarides-opam-repository that referenced this pull request Apr 3, 2024
CHANGES:

### Fixed

- Take into account the end date of the specified period when filtering github activity (tarides/get-activity#31, @gpetiot)

### Changed

- API: `Contributions.of_json` parameter `~from` is replaced by `~period` (tarides/get-activity#31, @gpetiot)
- Distinguish between issue comments and PR comments (tarides/get-activity#38, @gpetiot)
  API: new constructor `Comment` replacing `Issue_comment`

### Added

- Display curl requests and responses in debug mode (`-vv` or `--verbosity debug`) (tarides/get-activity#36, @gpetiot)
- Add the PR merge events to the contributions (tarides/get-activity#37, @emillon, @gpetiot)
  API: new constructor `Merge`
gpetiot added a commit to tarides/opam-repository that referenced this pull request Apr 3, 2024
CHANGES:

### Fixed

- Take into account the end date of the specified period when filtering github activity (tarides/get-activity#31, @gpetiot)

### Changed

- API: `Contributions.of_json` parameter `~from` is replaced by `~period` (tarides/get-activity#31, @gpetiot)
- Distinguish between issue comments and PR comments (tarides/get-activity#38, @gpetiot)
  API: new constructor `Comment` replacing `Issue_comment`

### Added

- Display curl requests and responses in debug mode (`-vv` or `--verbosity debug`) (tarides/get-activity#36, @gpetiot)
- Add the PR merge events to the contributions (tarides/get-activity#37, @emillon, @gpetiot)
  API: new constructor `Merge`
samoht pushed a commit to samoht/tarides-opam-repository that referenced this pull request Jul 23, 2024
CHANGES:

### Fixed

- Take into account the end date of the specified period when filtering github activity (tarides/get-activity#31, @gpetiot)

### Changed

- API: `Contributions.of_json` parameter `~from` is replaced by `~period` (tarides/get-activity#31, @gpetiot)
- Distinguish between issue comments and PR comments (tarides/get-activity#38, @gpetiot)
  API: new constructor `Comment` replacing `Issue_comment`

### Added

- Display curl requests and responses in debug mode (`-vv` or `--verbosity debug`) (tarides/get-activity#36, @gpetiot)
- Add the PR merge events to the contributions (tarides/get-activity#37, @emillon, @gpetiot)
  API: new constructor `Merge`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant