fix: update transactions.submit request #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
sdbondi
added a commit
to tari-project/tari-dan
that referenced
this pull request
Sep 18, 2024
Description --- Submit an UnsignedTransaction to the wallet for signing. Split dry run from submit (`transactions.submit` and `transactions.submit_dry_run`) Remove no_fee setting from validator node Motivation and Context --- Avoid confusion with `transactions.submit` API by removing duplicate data in request. The result field is removed from the transactions.submit response as that only applies to dry run. Dry run is submitted by using a separate request that returns the result in the response. tari.js will need to be updated (PR tari-project/tari.js#36) How Has This Been Tested? --- Cucumber, manually What process can a PR reviewer use to test or verify this change? --- Call `transactions.submit` Breaking Changes --- - [ ] None - [ ] Requires data directory to be deleted - [x] Other - Please specify BREAKING CHANGE: transactions.submit call has breaking changes, no_fees setting is removed from VNs (fees are required)
sdbondi
force-pushed
the
update-submit-api
branch
from
72d98b8 to
cb1eee7
Compare
sdbondi
force-pushed
the
update-submit-api
branch
from
cb1eee7 to
18366e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
updates to changes from tari-project/tari-dan#1151 and tari-project/tari-dan#1153
Version bump to v0.2.0
Motivation and Context
Updates to incorporate the improvements to the transaction submit API.