feat: new walletconnect button #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 17, 2024
github-merge-queue bot
pushed a commit
to tari-project/tari-dan
that referenced
this pull request
Jul 25, 2024
Description --- Adds support for WalletConnect in the `tari_wallet_daemon_ui`: * Adds new envvar `VITE_WALLET_CONNECT_PROJECT_ID` * New button to accept WalletConnect URIs * Implements the WalletConnect communication logic using the official JavaScript Wallet SDK * Requests are being forwarded to the wallet daemon Motivation and Context --- We want to support WalletConnect in Tari, as this is a de facto standard for web-to-wallet interaction. It will allow any wallet (web or mobile) to add support for Tari without us having to implement anything extra. In this context, the goal of this PR is to add support for WalletConnect in the Tari Wallet Daemon alongside the exising TariConnector. For now we have separated UI buttons for both TariConnector and WalletConnect, due do some TariConnect logic being entangled into the UI. It should be possible to refactor to only have one generic button that accepts both types of connection URIs but it was left out of the scope of this PR. See tari-project/tari.js#27 and tari-project/tari-template-web#6 for more information. How Has This Been Tested? --- Manually by running `tari_swarm`, opening the tari wallet daemon web UI and then paste a valid WalletConnect URI What process can a PR reviewer use to test or verify this change? --- See previous section Breaking Changes --- - [x] None - [ ] Requires data directory to be deleted - [ ] Other - Please specify --------- Co-authored-by: Stan Bondi <[email protected]>
github-merge-queue bot
pushed a commit
to tari-project/tari-dan
that referenced
this pull request
Jul 30, 2024
Description --- Adds support for WalletConnect in the `tari_wallet_daemon_ui`: * Adds new envvar `VITE_WALLET_CONNECT_PROJECT_ID` * New button to accept WalletConnect URIs * Implements the WalletConnect communication logic using the official JavaScript Wallet SDK * Requests are being forwarded to the wallet daemon Motivation and Context --- We want to support WalletConnect in Tari, as this is a de facto standard for web-to-wallet interaction. It will allow any wallet (web or mobile) to add support for Tari without us having to implement anything extra. In this context, the goal of this PR is to add support for WalletConnect in the Tari Wallet Daemon alongside the exising TariConnector. For now we have separated UI buttons for both TariConnector and WalletConnect, due do some TariConnect logic being entangled into the UI. It should be possible to refactor to only have one generic button that accepts both types of connection URIs but it was left out of the scope of this PR. See tari-project/tari.js#27 and tari-project/tari-template-web#6 for more information. How Has This Been Tested? --- Manually by running `tari_swarm`, opening the tari wallet daemon web UI and then paste a valid WalletConnect URI What process can a PR reviewer use to test or verify this change? --- See previous section Breaking Changes --- - [x] None - [ ] Requires data directory to be deleted - [ ] Other - Please specify --------- Co-authored-by: Stan Bondi <[email protected]>
github-merge-queue bot
pushed a commit
to tari-project/tari.js
that referenced
this pull request
Aug 7, 2024
Description --- * Adds a new provider for WalletConnect * Removed the `example` web page, as we already have [a project or that purpose](https://github.com/tari-project/tari-template-web). Motivation and Context --- See tari-project/tari-dan#1083 and tari-project/tari-template-web#6 for more context How Has This Been Tested? --- This can only be tested alongside the changes in the tari wallet daemon to support WalletConnect: tari-project/tari-dan#1083 What process can a PR reviewer use to test or verify this change? --- See previous section Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify --------- Co-authored-by: Stan Bondi <[email protected]>
sdbondi
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a work in progress that adds support for WalletConnect via a new connection option.
This can only be tested alongside tari-project/tari-dan#1083 and tari-project/tari.js#27
This PR depends on the PRs mentioned previously, so please do not merge before those.