Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default committee size #783

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

Cifko
Copy link
Contributor

@Cifko Cifko commented Nov 22, 2023

Description

The default committee size of 1 is breaking some tests.

Motivation and Context

How Has This Been Tested?

Running the failed cucumber tests New validator node registers and syncs and Template registration and invocation in a 2-VN committee

What process can a PR reviewer use to test or verify this change?

The CI should pass, or run the same test.

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other - Please specify

Copy link

Test Results (CI)

171 tests  ±0   171 ✔️ +2   1h 10m 17s ⏱️ - 20m 36s
  48 suites ±0       0 💤 ±0 
    2 files   ±0       0  - 2 

Results for commit ee800af. ± Comparison against base commit 26f8f82.

@stringhandler stringhandler added this pull request to the merge queue Nov 22, 2023
Merged via the queue into tari-project:development with commit 6d48db4 Nov 22, 2023
9 checks passed
@Cifko Cifko deleted the fix-committee-size branch November 27, 2023 10:05
@Cifko Cifko restored the fix-committee-size branch December 11, 2023 15:40
@Cifko Cifko deleted the fix-committee-size branch December 11, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants