Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template): add full typename to invalid argument error #1226

Merged

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Dec 24, 2024

Description

fix(template): add full typename to invalid argument error

Motivation and Context

Adding the type name to the error message makes it easier to determine an issue with a transaction.

Panic! failed to decode argument at position 0 (tari_template_lib::models::amount::Amount) for  function 'please_pass_invalid_args':

How Has This Been Tested?

Updated exiting unit test

What process can a PR reviewer use to test or verify this change?

Pass an invalid argument into a template

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other - Please specify

Copy link

Test Results (CI)

572 tests  ±0   572 ✅ ±0   1h 14m 40s ⏱️ - 16m 38s
 54 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit da2490f. ± Comparison against base commit 0f0496a.

@sdbondi sdbondi merged commit 973f8a1 into tari-project:development Dec 24, 2024
11 of 12 checks passed
@sdbondi sdbondi deleted the engine-include-type-in-error branch December 24, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants