Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(consensus)!: request/response protocol for foreign proposals + fixes #1215

Merged

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Dec 11, 2024

Description

  • fix(consensus)!: request/response protocol for foreign proposals + fixes
  • fix: last vote not to be included in NEWVIEWs
  • fix: transactions stuck in pool and never proposed in some cases
  • feat: add VN button to swarm
  • fix: pending transactions can be continued between epochs
  • fix: lock conflicts are removed when rejected(no vote) block is deleted
  • feat: send NEWVIEW as soon as NOVOTE is decided
  • fix: invalid dummy blocks when leader failure occurs after genesis block
  • tests: new dummy tests
  • tests: uncomment previously flaky eviction cucumber
  • fix: validate qc for newview

Motivation and Context

Fixes #1201

How Has This Been Tested?

Manually, cucumber and new tests. Tested num committees increasing from 1 to 2 in swarm

What process can a PR reviewer use to test or verify this change?

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other - Please specify

@sdbondi sdbondi force-pushed the consensus-propagation-protocol branch from b73fc6c to d1a679f Compare December 11, 2024 07:10
@sdbondi sdbondi marked this pull request as ready for review December 11, 2024 07:10
@sdbondi sdbondi force-pushed the consensus-propagation-protocol branch 3 times, most recently from c980bdc to 257b36e Compare December 11, 2024 07:41
@sdbondi sdbondi force-pushed the consensus-propagation-protocol branch from 257b36e to 76810c2 Compare December 11, 2024 09:13
Copy link

Test Results (CI)

588 tests   588 ✅  3h 52m 17s ⏱️
 66 suites    0 💤
  2 files      0 ❌

Results for commit 76810c2.

@sdbondi sdbondi merged commit 27e2516 into tari-project:development Dec 11, 2024
12 checks passed
@sdbondi sdbondi deleted the consensus-propagation-protocol branch December 11, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gossip and request strategy for foreign proposals
2 participants