-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: submit eviction proof for nodes that miss many proposals #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI)564 tests +3 564 ✅ +3 1h 35m 37s ⏱️ - 26m 31s Results for commit 05f48a3. ± Comparison against base commit 581a285. This pull request removes 3 and adds 6 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
sdbondi
force-pushed
the
consensus-evict
branch
from
December 5, 2024 13:13
05a68ef
to
fad7b69
Compare
sdbondi
force-pushed
the
consensus-evict
branch
from
December 9, 2024 05:33
5b200bc
to
8254695
Compare
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Dec 11, 2024
* development: feat!: submit eviction proof for nodes that miss many proposals (tari-project#1211)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat!: submit eviction proof for nodes that miss many proposals
various bug fixes
cucumber that tests end-to-end eviction
watcher submits the eviction transaction
fixes for epoch manager to allow exits
removed suspending and resuming nodes
exit consensus and sync if receiving a QC for a future epoch
Motivation and Context
If a node goes offline, consensus will run much more slowly due to having to wait for leader failure each round.
This PR implements the eviction command and generation of an eviction proof that can be submitted on L1. Once the epoch is reached where the eviction applies, the validator is removed from the committee. Requires tari-project/tari#6702
Suspending and resuming nodes adds complexity and some bugs were observed. Since evicted nodes are already immediately skipped in rounds by other validator nodes before they are evicted, the value of suspending nodes is limited and it was decided that it was not worth the added complexity.
How Has This Been Tested?
New unit tests and cucumber, manually
What process can a PR reviewer use to test or verify this change?
Breaking Changes
BREAKING CHANGE: incompatible global and state database changes