fix: remove epoch manager calls from consensus gossipsub #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
gossipsub-remove-epoch-manger-calls
branch
from
1701a01 to
e0cc1f8
Compare
3 tasks
sdbondi
added a commit
that referenced
this pull request
Oct 29, 2024
) Description --- fix(gossip): bug vn might not be subscribed to consensus messages Removed unused `ThisValidatorIsRegistered` epoch manager event Added `registered_shard_group` to `EpochChanged` event that is Some when local VN is registered for the epoch Motivation and Context --- Bug introduced in #1190 where VNs might not be subscribed to consensus messages. How Has This Been Tested? --- Manually, validator node that has been shutdown and restarted without the epoch changing was not subscribed to consensus messages What process can a PR reviewer use to test or verify this change? --- As above Breaking Changes --- - [x] None - [ ] Requires data directory to be deleted - [ ] Other - Please specify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: remove epoch manager calls from consensus gossipsub
Motivation and Context
Several epoch manager calls were used for message broadcasts, however, all required info obtained from these calls is already available at the consensus level, this PR removes the epoch manager dependency from consensus gossip only using the epoch manager events receiver.
Also directly encode and send the gossip message in the handle instead of first routing the message through the consensus gossip service and then to networking. The consensus gossip service is only responsible for ensuring that the node is subscribed to the correct shard group topic.
Increased gossipsub message limit to 1MiB to account for large foreign proposal messages which were rejected when testing. This is temporary and improvements to the protocol should allow us to reduce this.
How Has This Been Tested?
Manually
What process can a PR reviewer use to test or verify this change?
Slight and certainly unobservable performance improvements, this is a simplification PR
Breaking Changes