feat(validators): trickle in validators #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s' into origin/feature/trickle-validators
Test Results (CI)571 tests ±0 570 ✅ - 1 3h 36m 17s ⏱️ +18s For more details on these failures, see this check. Results for commit 09b57b8. ± Comparison against base commit 50e7b8c. ♻️ This comment has been updated with latest results. |
sdbondi
reviewed
Oct 21, 2024
dan_layer/epoch_manager/src/base_layer/base_layer_epoch_manager.rs
Outdated
Show resolved
Hide resolved
dan_layer/epoch_manager/src/base_layer/base_layer_epoch_manager.rs
Outdated
Show resolved
Hide resolved
dan_layer/epoch_manager/src/base_layer/base_layer_epoch_manager.rs
Outdated
Show resolved
Hide resolved
sdbondi
approved these changes
Oct 21, 2024
Merged
via the queue into
tari-project:development
with commit Oct 21, 2024
c423408
11 of 12 checks passed
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Oct 24, 2024
* development: feat(validators): trickle in validators (tari-project#1182)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow only a configurable amount of validator nodes to be active in an epoch, if we reach the limit, simply adding new validator nodes to a later epoch.
Example:
Let say that the max number of vns to be registered in an epoch is
2and there are10new validator nodes are trying to to join at the same time.Validator nodes table on other nodes (epochs are relative):
etc...
Motivation and Context
Validators were registered all at once, so when the registration form base layer has been processed, the new validators are available from the next epoch. The problem is that if there are thousands of thousands of validators joining the same time, it would cause the consensus to stuck for a longer period of time until it gets running again healthy.
How Has This Been Tested?
Current limit for developer networks is
50, so setting the number of validator nodes to a higher number than50is needed. Then starting up a fresh swarm using this new configuration (delete processes dir) and after the first 50 nodes are up an running, opendata/swarm/processes/validator-node-00/localnet/data/validator_node/global_storage.sqlitelocal database and checkvalidator_nodestable content.It will nicely show that the first 50 nodes are going to the next epoch, then the rest in the one after next one.
Then start periodic mining to get to a new epoch and see if everything still runs well with new validator nodes.
What process can a PR reviewer use to test or verify this change?
Breaking Changes