Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(consensus)!: suspend nodes that fail to participate #1181

Merged
merged 9 commits into from
Oct 24, 2024

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Oct 21, 2024

Description

  • suspend nodes that fail to participate in 3 rounds (configurable)
  • resume nodes after voting in 5 rounds
  • refactor and simplify leader failure

Motivation and Context

Reduce the impact of a nodes going offline by enabling nodes to agree to suspend the offending nodes from consensus rounds. Once suspended, nodes will immediately send a newview to the next functioning node.

How Has This Been Tested?

Unit test, manually 5 nodes taking one offline, observe suspension, go online, wait for resumed node instruction

What process can a PR reviewer use to test or verify this change?

As above

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other - Please specify

BREAKING CHANGE: 2 new block commands added

@sdbondi sdbondi force-pushed the consensus-count-votes branch 2 times, most recently from f53689c to 9782b6e Compare October 21, 2024 06:05
Copy link

github-actions bot commented Oct 21, 2024

Test Results (CI)

577 tests  +6   577 ✅ +7   3h 8m 48s ⏱️ - 19m 4s
 64 suites ±0     0 💤 ±0 
  2 files   ±0     0 ❌  - 1 

Results for commit a0eb58a. ± Comparison against base commit c423408.

♻️ This comment has been updated with latest results.

@sdbondi sdbondi force-pushed the consensus-count-votes branch from 5125aee to c55c923 Compare October 21, 2024 08:05
@sdbondi sdbondi requested a review from a team as a code owner October 21, 2024 08:05
leet4tari
leet4tari previously approved these changes Oct 21, 2024
Copy link
Contributor

@leet4tari leet4tari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - Can only say that the changes to the workflow should not break anything.

@sdbondi sdbondi merged commit d81722d into tari-project:development Oct 24, 2024
11 checks passed
@sdbondi sdbondi deleted the consensus-count-votes branch October 24, 2024 08:19
sdbondi added a commit to sdbondi/tari-dan that referenced this pull request Oct 24, 2024
* development:
  feat(consensus)!: suspend nodes that fail to participate (tari-project#1181)
  chore(deps-dev): bump vite from 4.5.3 to 4.5.5 in /applications/tari_swarm_daemon/webui (tari-project#1177)
  chore(deps-dev): bump vite from 4.5.3 to 4.5.5 in /applications/tari_dan_wallet_web_ui (tari-project#1178)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants