-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(consensus)!: suspend nodes that fail to participate #1181
Merged
sdbondi
merged 9 commits into
tari-project:development
from
sdbondi:consensus-count-votes
Oct 24, 2024
Merged
feat(consensus)!: suspend nodes that fail to participate #1181
sdbondi
merged 9 commits into
tari-project:development
from
sdbondi:consensus-count-votes
Oct 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
consensus-count-votes
branch
2 times, most recently
from
October 21, 2024 06:05
f53689c
to
9782b6e
Compare
sdbondi
force-pushed
the
consensus-count-votes
branch
from
October 21, 2024 07:04
9782b6e
to
5125aee
Compare
sdbondi
force-pushed
the
consensus-count-votes
branch
from
October 21, 2024 08:05
5125aee
to
c55c923
Compare
leet4tari
previously approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK - Can only say that the changes to the workflow should not break anything.
* development: feat(validators): trickle in validators (tari-project#1182)
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Oct 24, 2024
* development: feat(consensus)!: suspend nodes that fail to participate (tari-project#1181) chore(deps-dev): bump vite from 4.5.3 to 4.5.5 in /applications/tari_swarm_daemon/webui (tari-project#1177) chore(deps-dev): bump vite from 4.5.3 to 4.5.5 in /applications/tari_dan_wallet_web_ui (tari-project#1178)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Reduce the impact of a nodes going offline by enabling nodes to agree to suspend the offending nodes from consensus rounds. Once suspended, nodes will immediately send a newview to the next functioning node.
How Has This Been Tested?
Unit test, manually 5 nodes taking one offline, observe suspension, go online, wait for resumed node instruction
What process can a PR reviewer use to test or verify this change?
As above
Breaking Changes
BREAKING CHANGE: 2 new block commands added