fix(consensus): reduce output-only messaging,fix jmt error #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
conseusus-fixes
branch
from
14760e1 to
eebd59f
Compare
sdbondi
force-pushed
the
conseusus-fixes
branch
from
eebd59f to
7f41097
Compare
sdbondi
force-pushed
the
conseusus-fixes
branch
from
1247b56 to
219fe8a
Compare
sdbondi
force-pushed
the
conseusus-fixes
branch
from
25fb84f to
05ea983
Compare
sdbondi
force-pushed
the
conseusus-fixes
branch
from
05ea983 to
9439b69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Output only committees do not send LocalPrepare
Always use parent block ID to fetch JMT pending state.
Simplify evidence update apply to transaction pool record
Improve performance of missing transaction processing
Fix leader failure
Reduce/simplify prepare phase evidence
Avoid block propose delay when changing epochs
Motivation and Context
Output-only shard groups do not need to send prepare-phase cross-shard exchanges as they don't involve any inputs. This PR removes this pledging for output only nodes.
The previous pending JMT diffs query used the justify block_id. However, if the justify != parent, the JMT should include pending state for the parent since state changes will still be committed.
Fixes #1154
How Has This Been Tested?
Manually tariswap test and existing tests
What process can a PR reviewer use to test or verify this change?
Bug fixes
Breaking Changes