feat!: new account constructor for custom access rules #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
via the queue into
tari-project:development
with commit Sep 13, 2024
5431162
12 checks passed
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Sep 16, 2024
* development: fix(consensus)!: read-only resource + other fixes (tari-project#1134) test(cucumber): add concurrent wallet daemon call (tari-project#1140) feat!: new account constructor for custom access rules (tari-project#1138) test(cucumber): nft and fungible features (tari-project#1137) test(cucumber): enable counter template scenario (tari-project#1136) feat(consensus)!: add sidechain id in the genesis block (tari-project#1135)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CreateAccountinstruction typeMotivation and Context
When creating accounts we want to be able to specify custom access rules.
This PR refactors the account template constructor (
createfunction) to allow specifying the following fields:public_key_token: mandatory field. Needed always for component creation. If theowner_ruleis not set, it will be used to set up the default owner ruleowner_rule: optional field. Used to specify custom logic for the account component ownership (e.g. update the access rules after creation)access_rules: optional field. Used to specify custom access control rules over the account component methodsbucket: optional field. Initial funds of the accountHow Has This Been Tested?
custom_access_rulestari_spawnand checking it worksWhat process can a PR reviewer use to test or verify this change?
See previous section
Breaking Changes