-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: indexer event scanning is broken after epoch change #1121
fix: indexer event scanning is broken after epoch change #1121
Conversation
Test Results (CI)105 tests - 444 104 ✅ - 445 34m 17s ⏱️ - 55m 43s For more details on these failures, see this check. Results for commit 3751961. ± Comparison against base commit 7f0a322. This pull request removes 444 tests.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM small nits on the storage API
applications/tari_validator_node/src/p2p/rpc/block_sync_task.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
6dc89c8
Description
get_oldest_scanned_epoch
anddelete_scanned_epochs_older_than
to support the event scanningup_to_epoch
parameter (it was ignored previously)blocks_get_first_in_epoch
to support the new block sync logicMotivation and Context
Recently the epoch change logic was reworked, which broke the event scanning functionality in the indexer. This PR fixes it.
Fixes #1111
How Has This Been Tested?
Manually by running
tari_swarm
, doing transactions, and stopping/resuming the networkWhat process can a PR reviewer use to test or verify this change?
See previous section
Breaking Changes