-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(consensus)!: substate pledges #1119
Merged
sdbondi
merged 10 commits into
tari-project:development
from
sdbondi:consensus-pledging
Aug 21, 2024
Merged
fix(consensus)!: substate pledges #1119
sdbondi
merged 10 commits into
tari-project:development
from
sdbondi:consensus-pledging
Aug 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
consensus-pledging
branch
from
August 15, 2024 12:59
7d4c953
to
6237070
Compare
sdbondi
force-pushed
the
consensus-pledging
branch
3 times, most recently
from
August 16, 2024 13:33
3bf548a
to
225aa0b
Compare
sdbondi
force-pushed
the
consensus-pledging
branch
from
August 16, 2024 14:00
225aa0b
to
1da84e0
Compare
sdbondi
force-pushed
the
consensus-pledging
branch
from
August 19, 2024 06:11
4c0a09b
to
3bbcdea
Compare
sdbondi
force-pushed
the
consensus-pledging
branch
from
August 19, 2024 07:08
2868ab3
to
1d4f64f
Compare
3 tasks
mrnaveira
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with tari_swarm
, no issues found.
Merged
via the queue into
tari-project:development
with commit Aug 21, 2024
7f0a322
14 checks passed
sdbondi
added a commit
to sdbondi/tari-dan
that referenced
this pull request
Aug 21, 2024
* development: fix(consensus)!: substate pledges (tari-project#1119)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix(consensus)!: multi shard substate pledges
Version is not considered when calculating which preshard a substate belongs to
Fix several race conditions in consensus
Adds a test for all local inputs, foreign outputs
Build transactions with inputs in tests
Fixed mempool gossip
Motivation and Context
Implements cross-shard exchange and pledges for inputs/outputs.
TODO:
How Has This Been Tested?
Manually - multi-shard-group test, existing tests, new tests
What process can a PR reviewer use to test or verify this change?
Submit transactions to a multi-shard-group network
Breaking Changes
BREAKING CHANGE: SubstateAddress has increased in size by 4 bytes, new commands