Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(consensus)!: substate pledges #1119

Merged
merged 10 commits into from
Aug 21, 2024

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Aug 15, 2024

Description

fix(consensus)!: multi shard substate pledges
Version is not considered when calculating which preshard a substate belongs to
Fix several race conditions in consensus
Adds a test for all local inputs, foreign outputs
Build transactions with inputs in tests
Fixed mempool gossip

Motivation and Context

Implements cross-shard exchange and pledges for inputs/outputs.

TODO:

How Has This Been Tested?

Manually - multi-shard-group test, existing tests, new tests

What process can a PR reviewer use to test or verify this change?

Submit transactions to a multi-shard-group network

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other - Please specify

BREAKING CHANGE: SubstateAddress has increased in size by 4 bytes, new commands

Copy link

github-actions bot commented Aug 15, 2024

Test Results (CI)

549 tests  +549   549 ✅ +549   2h 4m 59s ⏱️ + 2h 4m 59s
 58 suites + 58     0 💤 ±  0 
  2 files   +  2     0 ❌ ±  0 

Results for commit 4278f20. ± Comparison against base commit 11931c1.

♻️ This comment has been updated with latest results.

@sdbondi sdbondi force-pushed the consensus-pledging branch from 225aa0b to 1da84e0 Compare August 16, 2024 14:00
@sdbondi sdbondi force-pushed the consensus-pledging branch from 4c0a09b to 3bbcdea Compare August 19, 2024 06:11
@sdbondi sdbondi force-pushed the consensus-pledging branch from 2868ab3 to 1d4f64f Compare August 19, 2024 07:08
Copy link
Collaborator

@mrnaveira mrnaveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with tari_swarm, no issues found.

@sdbondi sdbondi added this pull request to the merge queue Aug 21, 2024
Merged via the queue into tari-project:development with commit 7f0a322 Aug 21, 2024
14 checks passed
@sdbondi sdbondi deleted the consensus-pledging branch August 21, 2024 04:58
sdbondi added a commit to sdbondi/tari-dan that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants