-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(watcher): start validator node process #1116
Merged
sdbondi
merged 11 commits into
tari-project:development
from
therealdannzor:feat-tari-watcher-stage-2
Aug 12, 2024
Merged
feat(watcher): start validator node process #1116
sdbondi
merged 11 commits into
tari-project:development
from
therealdannzor:feat-tari-watcher-stage-2
Aug 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI)556 tests ±0 554 ✅ - 2 1h 49m 46s ⏱️ + 5m 36s For more details on these failures, see this check. Results for commit a5f5420. ± Comparison against base commit 7b914ce. ♻️ This comment has been updated with latest results. |
sdbondi
reviewed
Aug 12, 2024
sdbondi
reviewed
Aug 12, 2024
sdbondi
reviewed
Aug 12, 2024
sdbondi
reviewed
Aug 12, 2024
sdbondi
approved these changes
Aug 12, 2024
Merged
via the queue into
tari-project:development
with commit Aug 12, 2024
067bf14
11 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spawns the the
tari_validator_node
through a tokioCommand
but has not been tested fully with actual config. (It doesn't persist the child or even outlives its scope.)Breaking Changes