fix(bindings): remove dist from gitignore to expose build project #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
changed the title
sdbondi
previously approved these changes
Aug 9, 2024
sdbondi
approved these changes
Aug 12, 2024
4 tasks
github-merge-queue bot
pushed a commit
to tari-project/tari.js
that referenced
this pull request
Aug 12, 2024
Description --- Bump dependency [typescript-bindings](https://github.com/tari-project/tari-dan/tree/development/bindings) to the newest version with fixed build. Motivation and Context --- This is a part of larger process of fixing build for all javascript/typescript packages (check this [PR](tari-project/tari-dan#1115) in typescript-bindings repo). How Has This Been Tested? --- Changed locally tari.js dependency for tari universe and one of the tapplet. Both applications were working as expected with those changes. What process can a PR reviewer use to test or verify this change? --- Same as above. Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Last PR broke last @tari-project/typescript-bindings version. package.json points entrypoint as
./dist/index.jsbut since CI doesn't builds project every run (as it is costly) the package doesn't havedistfolder and effectively we don't export anything.Motivation and Context
Fix package for other projects like tari.js which relies on typescript-bindings.
How Has This Been Tested?
Imported locally build typescript-bindings with dist folder present.
Also imported the tari.js to the Tari Universe and to the faucet tapplet to check if project depending also on tari.js would work.
What process can a PR reviewer use to test or verify this change?
Eg. change typescript-bindings dependency for tari.js to local (in my case it's
"@tari-project/typescript-bindings": "file:../tari-dan/bindings",) and check if it's workingBreaking Changes