Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(watcher): validator watcher cli and config #1114

Merged
merged 4 commits into from
Aug 8, 2024
Merged

feat(watcher): validator watcher cli and config #1114

merged 4 commits into from
Aug 8, 2024

Conversation

therealdannzor
Copy link
Contributor

Description

Laying the groundworks for #1112 and the new application tari_watcher with basic cli and config

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other - Please specify

@therealdannzor therealdannzor requested a review from sdbondi August 7, 2024 17:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

Test Results (CI)

556 tests  ±0   556 ✅ +1   1h 42m 56s ⏱️ - 35m 17s
 65 suites ±0     0 💤 ±0 
  2 files   ±0     0 ❌  - 1 

Results for commit c185111. ± Comparison against base commit 6c1dbc6.

sdbondi
sdbondi approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! Can address comments in the next PR

applications/tari_watcher/src/config.rs Show resolved Hide resolved
applications/tari_watcher/src/config.rs Show resolved Hide resolved
applications/tari_watcher/src/config.rs Show resolved Hide resolved
applications/tari_watcher/src/config.rs Show resolved Hide resolved
@sdbondi sdbondi added this pull request to the merge queue Aug 8, 2024
Merged via the queue into tari-project:development with commit 001f797 Aug 8, 2024
12 checks passed
@therealdannzor therealdannzor deleted the feat-tari-watcher-stage-1 branch August 8, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdbondi sdbondi sdbondi approved these changes

Assignees
No one assigned
Labels
P-acks_required P-reviews_required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@therealdannzor @sdbondi @ghpbot-tari-project